fix(cli): correct dead api-key dashboard url and align brand to Onepin#61
Open
kj-podonos wants to merge 1 commit into
Open
fix(cli): correct dead api-key dashboard url and align brand to Onepin#61kj-podonos wants to merge 1 commit into
kj-podonos wants to merge 1 commit into
Conversation
The api-key dashboard URL app.onepin.ai/settings/api-keys 404s; the live path is app.onepin.ai/workspace/~/settings/api. It was duplicated across the CLI auth-error const, README, examples, and the bundled agent skill -- all now point at the live page (verified 200 against the running app). Also align user-facing prose to the docs brand casing 'Onepin' (login/skill error messages, --help text, docstrings, SKILL.md/reference.md). Code symbols (OnePinClient, OnePin*Error, ONEPIN_* env vars, X-OnePin-Required-Version) and the lowercase 'onepin' module name are untouched. Adds a test for the empty-payload branch of _bundled_skill_files so the brand edit on that line stays covered (diff-cover 100% on changed lines). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kj-podonos
added
bug
Contributor
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upstream followups from the public-docs SEO/GEO pass (onepin-sdks #27/#28) that live in this repo.
1. Dead API-keys dashboard URL → live path
https://app.onepin.ai/settings/api-keys404s. The live page ishttps://app.onepin.ai/workspace/~/settings/api(verified 200 against the running app).The dead URL was duplicated in 6 spots / 5 files — all fixed:
src/onepin/_cli/commands/auth.py_DASHBOARD_URLconst (drives bothlogininvalid-key errors)tests/cli/test_cli_login.pyREADME.md(×2)examples/README.mdsrc/onepin/_cli/_skill/onepin/SKILL.md2. Brand casing
OnePin→OnepinAlign user-facing prose to the docs' brand casing: CLI error messages
(
_ctx.py),--help/docstrings, and the bundled skill docs (SKILL.md,reference.md).Code symbols are untouched —
OnePinClient,AsyncOnePinClient,OnePinClientEnvironment,OnePin*Error,ONEPIN_*env vars,X-OnePin-Required-Version, and the lowercaseonepinmodule/PyPI name allstay verbatim. The generated SDK (everything under
src/onepin/except_cli/and
_version_gate.py) was not touched.Tests
Added
test_bundled_skill_files_empty_payload_raisescovering the empty-payloadbranch of
_bundled_skill_files, so the brand edit on that line stays covered.Verification
ruff check/ruff format --check/mypy -p onepin._cli— cleanpytest --cov=onepin._cli— 95.79% (≥80 gate)diff-cover --compare-branch=origin/main— 100% on changed lines (≥90 gate)onepin login --key bad→ error now prints…/workspace/~/settings/api;skill install --helpreads "Onepin".Notes
onepin loginprintsOnePin API key:— it doesn't; the prompt is the bare string"API key". No change needed.CHANGELOG.mdline 11 (sync SDK to OnePin API v0.38.12) is a historical, release-please-managed entry — left as-is.Out of scope (other repos)
donut-be spec title, Framer JSON-LD,
docs.ymltwitter/PostHog keys, post-deploy ops — tracked in their own repos.🤖 Generated with Claude Code